yearn-vaults icon indicating copy to clipboard operation
yearn-vaults copied to clipboard

Published 20 hours ago • verified publisher icon yearn

Depositor obtains BaseWrapper balance on pull deposit

Open skeletor-spaceman opened this issue 2 years ago • 1 comments

afterBal should be changed to deposited https://github.com/yearn/yearn-vaults/blob/b3f33bd5a8ece52b6504d0c1cd9029fb639d6349/contracts/BaseWrapper.sol#L182

also, pull boolean should be immutable, not sure there is a usecase for both pull and non-pull deposits

skeletor-spaceman avatar Apr 13 '22 15:04 skeletor-spaceman

I agree this is a bit confusing: perhaps using updatedBal or depositorBal might make this even more clear.

westonnelson avatar Apr 16 '22 21:04 westonnelson