yearn-vaults icon indicating copy to clipboard operation
yearn-vaults copied to clipboard

Published 20 hours ago • verified publisher icon yearn

feat: release 0.4.4

Open pandadefi opened this issue 2 years ago • 6 comments

Candidate for next release. Do not merge until it's ready for a release.

Change Log:

  • Remove balanceOf dependency for estimatedTotalAssets (airdrop protection)
  • allow harvest on same block as addStrategy
  • upgrade vyper 0.3.3
  • upgrade sol 0.8.x
  • add deposit/withdraw events
  • reduce BaseStrategy size
  • add setLockedProfitDegradation event
  • add FeeReport event
  • add NewPendingGovernance event
  • additional testing
  • remove BaseWrapper
  • remove yToken
  • prevent fork EIP712 replay

closes #153

pandadefi avatar Jul 20 '22 16:07 pandadefi

@storming0x Can you please have a in detail look at the transition from safe math to math, I see one issue was introduced but lucky for us tests got it: https://github.com/yearn/yearn-vaults/pull/542/commits/ed04590b9b8da187d0b2cfd869bca58954872256

pandadefi avatar Jul 21 '22 08:07 pandadefi

@storming0x Can you please have a in detail look at the transition from safe math to math, I see one issue was introduced but lucky for us tests got it: ed04590

yeah this one seems to match what we have on the branch here https://github.com/yearn/yearn-vaults/blob/887d9091b699651843e74f130ba9940fe7053f19/contracts/BaseStrategy.sol#L736

Also diff here from the 0.4.3-sol8 branch vrs BaseStrategy here https://www.diffchecker.com/Su6r0fw9 LGTM!

storming0x avatar Jul 21 '22 20:07 storming0x

Do not merge into master yet. We have to make a rc tag to start using it while we are doing audit.

pandadefi avatar Jul 26 '22 16:07 pandadefi

  • vyper 3.4 borked the tests for me, but the previous commit using 3.3 looked fine (passed manual inspection/testing)

latest commit rollbacks to 0.3.3 FYI

storming0x avatar Aug 01 '22 18:08 storming0x

Associated PR: https://github.com/yearn/brownie-strategy-mix/pull/88

pandadefi avatar Aug 25 '22 08:08 pandadefi

can we squeeze this in? https://github.com/yearn/yearn-vaults/issues/545

banteg avatar Sep 05 '22 23:09 banteg

I will merge this into master and cut 0.4.4 release if none express any issues @storming0x @banteg @rareweasel

pandadefi avatar Oct 24 '22 09:10 pandadefi

I will merge this into master and cut 0.4.4 release if none express any issues @storming0x @banteg @rareweasel

asking in the protocol group so we are sure that we are all in sync w the plan

storming0x avatar Oct 24 '22 15:10 storming0x