yearn-vaults
yearn-vaults copied to clipboard
Add linting to CI for Vyper files
Currently have linting for Python and Solidity files, but not Vyper.
Add linting support + hook up to Github workflows.
Note: a tool doesn't exist for this yet, but it is possible to make one using Vyper's public API (which can output the AST)
I'm looking into creating such a tool. Is there any chance for compensation in case it resolves this issue? (Not asking for specific numbers, but would be nice to get something)
@spinoch yes! I think I can find some individuals that can put together a bounty if you are willing to help take this on!
Cool. I'll see if I can come up with something by next week
Hey @spinoch! It seems that you've done a lot of progress in the PR. Are you still working on it?
Hey, @fameal . In short, no. We need to fix a few issues in the blackadder repo and I haven't had time lately. I still would like to get the issues fixed but I can't really give a time frame atm
I have submitted a PR to fix this outstanding issue. https://github.com/yearn/yearn-vaults/pull/479
We need someone to build and maintain a linter. The linter should be able to work with multiple versions of vyper
We need someone to build and maintain a linter. The linter should be able to work with multiple versions of vyper
note that @spinoch made a first cut of it here: https://github.com/vyperlang/blackadder
@fubuloubu I would like try to finish the remaining work. I have looked through the PR(https://github.com/yearn/yearn-vaults/pull/52), the remaining work is to (correctly) reformat code for mutability of the method, am I right?
@fubuloubu I would like try to finish the remaining work. I have looked through the PR(#52), the remaining work is to (correctly) reformat code for mutability of the method, am I right?
No, there is updates needed to the tool for it to work
@fubuloubu Yeah, I have checked the tool(https://github.com/vyperlang/blackadder), currently it is simply based on regexp, should I modified it according to the AST to make a normal formatter? Or maybe fork the black(https://github.com/psf/black), and modified the code according to the grammar rule of Vyper?
@fubuloubu Yeah, I have checked the tool(https://github.com/vyperlang/blackadder), currently it is simply based on regexp, should I modified it according to the AST to make a normal formatter? Or maybe fork the black(https://github.com/psf/black), and modified the code according to the grammar rule of Vyper?
Will accept PRs to that repo, yes
Cool, I will try it.
Is there any advance in creating a linter for vyper ?
actually yeah, https://github.com/vyperlang/mamushi got a little further in terms of what it can do