xuzifu666

Results 66 comments of xuzifu666

> Sorry, I'm not a commiter to Apache Calcite and lack context to form an opinion on this change. get

@danny0405 Teacher Chan, the api is not used in Calcite, want to refactor it throght remove it for other developers not use the api,thanks

7958 or 7954 @Johnsonginati

> @xuzifu666 Thanks for contribution. This pr add throw exception in each write handlers. Is it possible to check all write statuses for failures during the commit phase? Good advice,I...

@bvaradar All had addressed,could you give the final review and give more advices?

> Do you think you can provide a test coverage to protect your contribution from potential future regression, @xuzifu666 ? > > > Not need @dongjoon-hyun Thanks for your attentions,In...

@dongjoon-hyun Could you give a final review? Thanks