[Minor] Refactor Matcher class with remove removePartialMatch

Open xuzifu666 opened this issue 3 years ago • 4 comments

removePartialMatch is useless in Mather，and avoid be used by other function remove it

Oct 08 '22 08:10 xuzifu666

@bchapuis have a review please, thanks

Oct 08 '22 08:10 xuzifu666

Sorry, I'm not a commiter to Apache Calcite and lack context to form an opinion on this change.

Oct 08 '22 09:10 bchapuis

Sorry, I'm not a commiter to Apache Calcite and lack context to form an opinion on this change.

get

Oct 08 '22 09:10 xuzifu666

@danny0405 Teacher Chan, the api is not used in Calcite, want to refactor it throght remove it for other developers not use the api，thanks

Oct 08 '22 10:10 xuzifu666

It is public method, maybe some uses use it. We should not remove it unless there is a better method for users.

Oct 13 '22 05:10 JiajunBernoulli