hudi
hudi copied to clipboard
apache
[HUDI-7208] Do writing stage should shutdown with error when insert failed to reduce user execute time and show error details
Change Logs
when user execute merge into or insert into to a table，if source table data is not right（such as source schema is not consistent to target table），should shutdown and throw error details to user，this can reduce cost of job and indicate more message for user to dig questions，job is not error evenwhen data insert occur error，this would misstake user and cost more compute time which is not necessary，like the pictures：
stage status show success，but had been failed due to writing failed，details in : https://issues.apache.org/jira/browse/HUDI-7208
Impact
none
Risk level (write none, low medium or high below)
low
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change
- The config description must be updated if new configs are added or the default value of the configs are changed
- Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the ticket number here and follow the instruction to make changes to the website.
Contributor's checklist
- [ ] Read through contributor's guide
- [ ] Change Logs and Impact were stated clearly
- [ ] Adequate tests were added if applicable
- [ ] CI passed
@xuzifu666 Thanks for contribution. This pr add throw exception in each write handlers. Is it possible to check all write statuses for failures during the commit phase?
@xuzifu666 Thanks for contribution. This pr add throw exception in each write handlers. Is it possible to check all write statuses for failures during the commit phase?
Good advice，I would change it
CI error seems not relete to the changed code，and Azure CI is success @danny0405
@bvaradar All had addressed，could you give the final review and give more advices?
