Leon Yang

LGTM

@gbzy Can you give more information on how to reproduce the bug

Plz close this issue since pr had been merged @sunnyholyd

@itinycheng Sorry to miss this issue. You are right, it's better to use the primary key as keyFields. And we can use SQL hint if someone needs to custom keyFields.

Yes, we don't support it yet. https://github.com/tidb-incubator/TiBigData/blob/master/trino/src/main/java/io/tidb/bigdata/trino/tidb/TiDBMetadata.java should implement these [two interfaces](https://github.com/trinodb/trino/blob/master/core/trino-spi/src/main/java/io/trino/spi/connector/ConnectorMetadata.java#L505-L526) in order to support 'CREATE TABLE ... SELECT'. But since TiDB doesn't support 'CREATE TABLE ... SELECT', we...

/run-all-tests

/run-all-tests

https://github.com/pingcap/tispark/issues/2331

https://github.com/pingcap/tispark/issues/959

/run-all-tests