tispark icon indicating copy to clipboard operation
tispark copied to clipboard

Only do auth check for tables in TiDB

Open TrafalgarRicardoLu opened this issue 2 years ago • 2 comments

What problem does this PR solve?

Only do auth check for tables in TiDB.

What is changed and how it works?

We will check the catalog name of operation. If it doesn't use tidb_catalog, we won't do auth check for it.

Check List

Tests

  • Unit test
  • Integration test

TrafalgarRicardoLu avatar Aug 04 '22 09:08 TrafalgarRicardoLu

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Daemonxiao
  • shiyuhang0

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment. After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.

ti-chi-bot avatar Aug 04 '22 09:08 ti-chi-bot

It's better to add some test

shiyuhang0 avatar Aug 08 '22 03:08 shiyuhang0

/run-all-tests

xuanyu66 avatar Aug 12 '22 06:08 xuanyu66

/merge

shiyuhang0 avatar Aug 13 '22 11:08 shiyuhang0

This pull request has been accepted and is ready to merge.

Commit hash: c6f54d1c437349708a497c2a89dff7018e74e4ad

ti-chi-bot avatar Aug 13 '22 11:08 ti-chi-bot

cherry pick to release-release failed

ti-srebot avatar Aug 13 '22 11:08 ti-srebot

In response to a cherrypick label: new pull request created: #2498.

ti-chi-bot avatar Aug 13 '22 11:08 ti-chi-bot

In response to a cherrypick label: new pull request created: #2499.

ti-chi-bot avatar Aug 13 '22 11:08 ti-chi-bot