tispark
tispark copied to clipboard
pingcap
[REFACTOR]Normalize pdclient to client-java(ignore batchGetRetryTest)
What problem does this PR solve?
tikv/client-java#514
Replace existing tispark/tikv-client module with upstream tikv/clien-java module.
What is changed and how it works?
module tikv-client-java
-
build (shell and maven)
use tikv./client-java dependency
remove dependences (
kvproto,raft_rs) -
keep existing packages/class
keep existing packages
allocator
catalog
codec
columnar
expression
jdbc
key
meta
operation
parser
partition
predicates
row
statistics
types
move packages
move key/Handle -> handle move tools > util
keep existing class
TiConfiguration
Snapshot
...
-
remove
event
exception
operation
pd
policy
region
streaming
txn
remove class
PDClient
TiSession
...
-
create new Class
ClientSession (holds TiConfiguration,Snaoshot and upstream/TiSession )
ConverterUpstream ( converte tispark/TiConfiguration to tikv/client-java/TiConfiguration)
module sprak-wrapper and module core
- use ClientSession calls replace TiSession.
problems encountered
-
test("batch get retry test") The test failed because the upstream client-java did not solve issue
pingcap/tispark#1905. After investigation, this test does not affect the normal function and belongs to the optimization test. The solution is to ignore and wait for the upstream repair before updating the dependencies.
Check List
Tests
- Unit test
- Integration test
[REVIEW NOTIFICATION]
This pull request has been approved by:
- Daemonxiao
- shiyuhang0
To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.
The full list of commands accepted by this bot can be found here.
Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.
/run-all-tests tidb=master tikv=master pd=master tiflash=master test-flash=true
fail