Rui Yang
Rui Yang
@sagikazarmark the PR is updated. Thx for the reviewing. We will submit a PR to dex docs too. BTW, in the readme `https://dexidp.io/docs/connectors/oauth/` is somehow broken as in the connector...
@sagikazarmark just a quick raincheck here to see if this PR falls in the path. I am seeing some connectors providing TLS config (more or less). For example, Github: https://github.com/dexidp/dex/blob/6cdbb594064740794a79f30da83be92ec06c22e8/connector/github/github.go#L99-L108...
Hi could I get some feedbacks on thie PR? Thx @sagikazarmark
@karunchennuri yes we have similar use case thus we implemented this in our fork https://github.com/concourse/dex. Not sure how it is gonna be in upstream.
@karunchennuri glad it works. The test could be ran using the `Makefile` https://github.com/dexidp/dex/blob/2ca992e9b359eff69f9886d10620f255c4cff2f2/Makefile#L44-L45 ```bash make test ```
@mvdkleijn absolutely. Most of my PRs got conflicts I will update all of them. Thank you!
@sagikazarmark could I get some feedback on this PR please?
> @xtremerui I've added some changes to your original PR that fix a few problems. See: [kellyma2@a4414c2](https://github.com/kellyma2/dex/commit/a4414c271d5510d76ebff696da93f889ca1e6d7a) > > Can you add them to this PR? @kellyma2 Sure thing. Thx...
Appreciate the input from you all! Here is how Concourse uses client credentials grant for its worker node. First, we use Dex as a [third party library in Concousre](https://github.com/concourse/concourse/blob/master/go.mod#L20). Typically,...
What is the version looks like of your resource? If the sha comes from a resource check then it makes sence to pull using that sha.