dex icon indicating copy to clipboard operation
dex copied to clipboard

Published 20 hours ago • verified publisher icon dexidp

TLS configure for OIDC connector

Open xtremerui opened this issue 5 years ago • 2 comments

This PR adds two configurable fiels RootCAs and InsecureSkipVerify to OIDC connector. When openning a connection to OIDC connect provider, it will use a httpclient based on these two fields.

xtremerui avatar Jan 20 '20 17:01 xtremerui

@sagikazarmark just a quick raincheck here to see if this PR falls in the path. I am seeing some connectors providing TLS config (more or less). For example,

Github: https://github.com/dexidp/dex/blob/6cdbb594064740794a79f30da83be92ec06c22e8/connector/github/github.go#L99-L108

LDAP: https://github.com/dexidp/dex/blob/6cdbb594064740794a79f30da83be92ec06c22e8/connector/ldap/ldap.go#L255-L269

openshift: https://github.com/dexidp/dex/blob/6cdbb594064740794a79f30da83be92ec06c22e8/connector/openshift/openshift.go#L81-L84

Thank you for your time!

xtremerui avatar Nov 05 '20 04:11 xtremerui

Hi could I get some feedbacks on thie PR? Thx @sagikazarmark

xtremerui avatar Nov 10 '21 18:11 xtremerui

@xtremerui Thanks for your work, and sorry for this PR being delayed for so long. My apologies.

I am ready to merge this. Could you please fix the conflicts?

nabokihms avatar Nov 04 '22 12:11 nabokihms

@nabokihms thx its done.

xtremerui avatar Nov 05 '22 01:11 xtremerui