dex icon indicating copy to clipboard operation
dex copied to clipboard

Published 20 hours ago • verified publisher icon dexidp

CloundFoundry connector

Open xtremerui opened this issue 5 years ago • 8 comments

Support for authenticating against CloudFoundry

Documentation of CloudFoundry UAA server

cc @pivotal-jwinters

xtremerui avatar Jan 13 '20 17:01 xtremerui

Hi, just checking back. Since there is no feedback here yet so I am wondering are there certain requirements to meet for Dex to add a new connector? Is there a way to move forward for this PR or its just a simple Nah not this connector?

Thank you for your time.

xtremerui avatar May 25 '20 15:05 xtremerui

Our team is also interested in this connector to adopt dex. I saw it used to be supported but seems to be gone now: https://github.com/dexidp/dex/pull/542/files Is there anything we can do to move this forward? Thanks!

Albertoimpl avatar Jul 29 '20 10:07 Albertoimpl

@xtremerui This also has merge conflicts... :smile:

mvdkleijn avatar Jul 30 '20 08:07 mvdkleijn

@sagikazarmark I kown there must be lots of pending PRs in your list. Just wanted to get some feedback here so we could move forward. Thx!

We assume that a PR to dexidp/website to include the doc is needed. Then we will update README.md here.

xtremerui avatar Mar 05 '21 17:03 xtremerui

Generally, we are against adding new connectors to the codebase (at least until #1635 is figured out), but I'd hate to see all this work going to waste.

Another reason that keeps us from adding all potential connectors is the lack of resources to support/test them.

If we were to add CloudFoundry as a connector, it would be labeled as a "community maintained" connector, until we can figure out a way to move it out of the core as a plugin of some sort. We would refer to you whenever someone reports an issue.

Would that be acceptable for you @xtremerui ?

sagikazarmark avatar Oct 03 '22 16:10 sagikazarmark

@sagikazarmark that's fair enough. Concourse team would have a better set of tooling to maintain this connector. Once connectors are out of the core, Concourse org would take ownership of cloudfoundry connector as well.

xtremerui avatar Oct 03 '22 20:10 xtremerui

@xtremerui let me know if you think this is ready.

And you are right: some sort of documentation would be nice. At least adding it to the list of connectors.

sagikazarmark avatar Oct 03 '22 20:10 sagikazarmark

@sagikazarmark the PR is updated. Thx for the reviewing.

We will submit a PR to dex docs too. BTW, in the readme https://dexidp.io/docs/connectors/oauth/ is somehow broken as in the connector listing, though the PR for oauth doc is already merged.

xtremerui avatar Oct 05 '22 15:10 xtremerui