Mete Fatih Cırıt

Results 304 comments of Mete Fatih Cırıt

https://github.com/autowarefoundation/autoware.universe/assets/10751153/c6901611-befb-4aba-893b-c632f8221e4b Visualization part is finished, it works well. The ETA calculation is so bad.

Applied the max_velocity to the remaining time calculation. It now estimates the remaining time more stable and reliable. In the following test, with 2 red lights: - **Estimated:** 1.9 mins...

![2024-05-11_03-10](https://github.com/autowarefoundation/autoware.universe/assets/10751153/3d33e655-c5e8-42bd-8eda-6584467bff5c) ➡️ ![2024-05-11_03-06](https://github.com/autowarefoundation/autoware.universe/assets/10751153/4afb0b70-946d-4c9d-8a0f-80103d378738) Bottom right side was looking a bit emptier than the bottom left side. So I've enlarged the inner rect to account for visual gap.

@soblin Sobue-san, are you actively working on this task? If not we can assign it to an Autoware Labs member since it may be failing some scenarios.

@tomas-pinto do you have any progress in this task?

I've ran with this branch, it compiled and planning simulator worked alright. Then to see if I was testing the correct things, I've renamed the contents of https://github.com/autowarefoundation/autoware.universe/blob/main/planning/behavior_path_external_request_lane_change_module/plugins.xml and added...

> @xmfcx Just running a test of the package is fine. Thank you. @takayuki5168 -san meant this for the static_centerline_generator pr. After talking with him, I learned that if I...

Thank you for your patience. I have approved the PR. Once the required CIs pass successfully, I will proceed with the merge manually. Since I am not a code owner...

I'm sorry that I keep finding these in separate reviews but this needs to be updated too: https://github.com/autowarefoundation/autoware.universe/blob/d47430cdab35b3447b4ff4be3ca6e1e6da027f02/launch/tier4_planning_launch/launch/scenario_planning/lane_driving/behavior_planning/behavior_planning.launch.xml#L223 to: ` ` I've found this by searching for `behavior_velocity_planner::BehaviorVelocityPlannerNode` in the...