Mete Fatih Cırıt

Results 304 comments of Mete Fatih Cırıt

Closing this issue with both PRs are merged, thanks @KhalilSelyan !

@kenji-miyake @mitsudome-r @esteve maybe we can also discuss about whether we should build these packages as part of the CI or not. Or discuss whether we should do the proposal...

So, I have thought about this more generally and here are the things I'd like to achieve: - Users shouldn't be forced to build drivers that they won't use. -...

@kenji-miyake I think we should add a rule in documentation to not allow binary image contributions. (I don't know if it's practical to add a CI check for this.) Maybe...

For example, Following file: https://github.com/autowarefoundation/autoware.universe/blob/main/planning/behavior_path_planner/image/avoidance/avoidance_design.fig1.drawio.svg Has no reason to be this large. But it has many binary images inside which can be replaced with vector images.

@VRichardJP thanks, I didn't know Inkscape could do it too. I could get following in Illustrator following https://helpx.adobe.com/illustrator/using/image-trace.html ![Asset 1](https://user-images.githubusercontent.com/10751153/235068956-474bd10d-30e2-4912-9f4d-3b76a0483e06.svg) > I'm not sure, but it might have some meta...

> By the way, how critical is this issue? Do you have any specific problems caused by the repository size? I'd say it has normal priority. Keeping repo small in...

> @xmfcx I remember you said we can consider utilizing `git-lfs` for images. > Did you find any problem with git-lfs and change your mind? We had a discussion with...

Debugging steps: - Turn off some Autoware plugins from RViz2 config utilizing a [manual binary search pattern](https://simple.wikipedia.org/wiki/Binary_search) to find out which one is causing the issue. - Isolate the problematic...

This will wait until - https://github.com/scop/pre-commit-shfmt/issues/20 is resolved.