Xavier Claessens
Xavier Claessens
I ran this PR on a bunch of projects I have and they all passed now, good job! LGTM as far as I'm concerned, but I think @eli-schwartz wanted to...
IMHO regressions are inevitable but also really easy to fix in this case I think. I agree with @dcbaker this has been waiting too long already and rebasing must be...
> That seems to add an option for vs startup project even on backends that do not have anything to do with VS. Basically it would mean that every backend...
I'm not exactly sure what does the startup project with vs backend, but if it's a way to tell the IDE which executable to run when pressing the play button,...
> What would vscode-meson do to retrieve its value? Could be part of introspection data. More generally, I think there is nothing specific to visual studio here. A default run...
Other than those small comments, the meson part looks good to me, it's a nice cleanup.
It's not a Windows specific issue, Linux also have some extra system libs needed for Rust stdlib. See for example that Meson unit test: https://github.com/mesonbuild/meson/blob/master/test%20cases/rust/5%20polyglot%20static/meson.build.
With https://github.com/mesonbuild/meson/pull/11790 Meson can already add system libs for Rust std, but we still need a way to get extra libs from Cargo.toml for libs used with e.g. `#[link(name =...
Adding to this topic, it would be nice to have the information when crate is built with `no-std` so Meson knows to _not_ link with system libraries needed for Rust's...
I was not aware of this thread, and there is indeed something to do in Rust as well... https://github.com/rust-lang/rust/issues/114013. FWIW, I find Rust's `foo.dll.lib` name for import lib makes sense....