Xavier Claessens

Results 101 comments of Xavier Claessens

I think this issue should be reopened because changing checksum of release tarball is not acceptable. You should not rely on GitHub generated tarballs, but upload your own when doing...

That can be scripted, WrapDB does it: https://github.com/mesonbuild/wrapdb/blob/master/tools/create_release.py#L118

But it seems GitHub is going to revert this change: https://github.com/bazel-contrib/SIG-rules-authors/issues/11#issuecomment-1409438954

I like the idea of moving stuff to a class, but needs a big rebase indeed.

I think it would be better to set `exe.verbose` to True in the cases we want, it has the advantage of not capturing potentially long output into memory before dumping...

I think you can add `verbose=True` here: https://github.com/mesonbuild/meson/blob/master/mesonbuild/interpreter/mesonmain.py#L103. That will make postconf/dist/install scripts output to stdout directly without buffering.

I'm sorry to contradict what I said previously, but I'm starting to think this should be its own `status()` (or `status_message()`?) function because it seems we have ideas to grow...

I did not follow the conversation too much, but we could bundle tomli in meson as fallback of importing the module from std failed?

Also, any reason Mesa cannot just use cargo in a custom_target() or using external-project module? To be honest I find the cmake module barely usable and a *giant* maintaining burden...