libva
libva copied to clipboard
intel
Misc meson fixes
Nothing overly fancy here, small cleanup proper docs/doxygen handling and a fancy summary()
@ceyusa as the original author of the meson build, do you mind having a look?
Added an extra commit on top, switching to features. I've initially hesitated since it does make a small backwards incompatible change - see commit for details.
Feel free to drop it, or if you prefer I can re-spin the series integrating it earlier in the PR.
There is also https://mesonbuild.com/Build-options.html#deprecated-options but then you'd have to bump the minimum meson to something very new. :(
There is also https://mesonbuild.com/Build-options.html#deprecated-options but then you'd have to bump the minimum meson to something very new. :(
Indeed, that's why I opted out. One thing that I was wondering:
Would it make sense if feature understands synonyms (yes, on, enabled) and (no, off, disabled) respectively. I see you have got lots of meson under your belt so feel free to propose/pick this, assuming it makes sense.
What would be the advantage of the synonym, other than the infrequent case that one migrates from a custom combo option that uses those strings?
@XinfengZhang any objections if we merge this for the next aka 2.17 release? Obviously I would need to rebase it on top of the va-win32 addition that just landed.
Rebased the the PR with couple of small changes:
- pushed the "use meson features" earlier in the series
- make win32 a feature like the rest cc @sivileri
@XinfengZhang @dvrogozh as mentioned earlier, I would love it this can make it for 2.17.
@XinfengZhang @dvrogozh humble ping? Is there anything I can do to move this forward?
Bear in mind that the last commit will conflict, albeit trivially, with https://github.com/intel/libva/pull/656
Other than those small comments, the meson part looks good to me, it's a nice cleanup.
