Wilson Snyder comments

Results 1229 comments of


                                            Wilson Snyder

Coverage breaks expressions with `this`

I suspect in V3EmitV just visit(AstThis) and print "this".

Coverage breaks expressions with `this`

I pushed the trivial V3EmitV change, but I think more is needed, when @toddstrader gets a chance.

Coverage breaks expressions with `this`

@toddstrader this example passes with `--coverage`, can we close it, or more left?

Coverage breaks expressions with `this`

I'd suggest excluding all out-of-bounds from coverage, that is the bounds check is ANDed with all coverage increment equations. Ideally we'd also have an "out-of-bounds" bin. (NOT out-of-bounds equation). To...

Fix finding signals in interface above class

Probably similar fix as to whatever's needed for #5212 - this one might be easier to fix first though. As always due to large backlog pull requests to fix this...

Fix finding signals in interface above class

Simplified test: ``` package Pkg; virtual class BFM; pure virtual task write (int unsigned data); pure virtual task read (output int unsigned data); endclass endpackage interface TB_intf(input bit PCLK); import...

Fix finding signals in interface above class

Passes in master, presume due to #6416 fix.

Fix inouts on deep and/or statements consuming all memory

We'll need an minimized example to debug. Please attach an openly licensed, completely self-contained test case so we can directly run what you provide. Ideally use test_regress format, see https://veripool.org/guide/latest/contributing.html?highlight=test_regress#reporting-bugs

Fix inouts on deep and/or statements consuming all memory

I'll take a look when get a chance, but you shouldn't be using inouts there, use output for id_4 and inputs for the rest.

Fix inouts on deep and/or statements consuming all memory

V3Tristate goes O(n^2) building the tree. Needs some work to fix; avoid for now `inout` on huge and/or statement.s