Steve Wood

Results 130 comments of Steve Wood

One aspect that seems to be missing so far are unit tests for the new function that is introduced.

Tests should be in the form of Python units that assert correctness of result etc. See the many examples here https://github.com/Qiskit/qiskit-terra/tree/main/test/python for various aspects. Unit tests are run by CI...

@anupamaray While I was able to help you with procedure/mechanics for the PR the material is not a subject area I can technically review the content. Someone from terra-core team...

Great, looking forward to having this a more generic algorithm here. As a general comment, here in Terra there should no longer be any references/use of Qiskit Nature. I think...

Also make sure the files here are formatted with the latest version of black. CI checks if they would be reformatted and fails if they would be (no reformatting is...

Fidelity interface and a compute/uncompute fidelity were implemented for this in #8303 which has been merged so closing this as completed.

Really the main difference is around creating the qubit operator from the molecule as Nature does things a bit different. In Nature you have a driver as before but now...

The tutorials that are here on optimization have been moved to the new qiskit-optimization repo and refactored. These here will shortly be removed. So the vehicle routing one is here...