Steve Wood
Steve Wood
Having the data all at once at the end seems fine - more of a post-mortem approach. The callback allows one to monitor as things are progressing, so in my...
> I note that estimate_observables now returns the variances and shots if obtained from metadata (and sets these to 0.0 otherwise). Should I add this for the main eigenvalue too?...
> were you referring to the aux_ops_eigenvalues that already return the variance?? Yes, there the variance is already taken out of the metadata - the resultant tuple of (variance, shots)...
In thinking about the comments in a different PR #8695 I am wondering whether it would be a good idea to add OptimizerResult to the VQEResult. Generally as we have...
LGTM like #8651 lets get the new algos merged and merge this afterwards.
We had a discussion when you first created the optimizer on `history` - you will see pretty much the same is being said now as then https://github.com/Qiskit/qiskit-terra/pull/8084#discussion_r900439353 Maybe having the...
Then maybe as I suggested earlier, as an alternative, defining a callback that the user can provide which allows the values to be monitored as the optimizer is running. A...
> The code is ready to be reviewed. Thanks,. I'll try and get to it soon, things have been extremely busy with the imminent release.
The `evolvers` package will be pending deprecation as of this upcoming release and will be deprecated and removed later. These files should now be introduced into the `time_evolvers` package.
> > The evolvers package will be pending deprecation as of this upcoming release and will be deprecated and removed later. These files should now be introduced into the time_evolvers...