Steve Wood

Results 137 comments of Steve Wood

>Yes, I was refering to the documentation. I thought we had to make getters and setters in order to properly document the class, but I am seeing that there has...

Hi. At present the existing algorithms in Qiskit Terra are being refactored to use the primitives (samplers and estimators) that have been introduced to Qiskit (existing algorithms are all being...

It seems that there are some fidelity tests for mismatched left and right circuits that are testing the sampler usage by fidelity to presumably ensure its catching the expected error...

Hi. At present there is significant refactoring going on for algorithms moving them over to use primitives.. This affects all algorithms, including the `(minimum_)eigen_solvers` which are being reworked in different...

I think having this PR open is ok. If you prefer to do a separate PR later, which maybe is easier, this can be closed off at that point. For...

BTW The CLA issue and avoiding it going forwards - either ensure the email in your git config is one of the ones known in your github account, or add...

The `main` branch here should be the one - that is what the refactored VQE and VQD are using/based off. You can see the changes in these and if its...

Sure, once #8640 gets merged, which should be soon, that new location is where I would expect an SSVQE to be. This folder does not yet exist in main, that...

In #8702, since the algorithms are now in a subfolder and need to be imported from there to avoid name collisions, the unit tests for the new algorithms were added...

@Cryoris See also my DM to you for some comments