Wenzel Jakob

Results 440 comments of Wenzel Jakob

Just to clarify: there is some issue with `scalar_rgb_double`, correct? (and the other radiancemeters give the expected result?) Is this a new bug? (i.e. something that worked previously).

Hi Vincent, thanks for the PR! As you already hint in the message, we won't merge it as-is, but this will be super-helpful in setting up the infrastructure for the...

Hi @leroyvn, I was just looking at the PRs you mention. It was actually not 100% clear what the issue with `DirectionSample.endpoint` was, can you clarify? There are some unrelated-seeming...

Hi Vincent, I just took another look at this PR and thought a bit more about the 'shape' target feature common to this sensor and 'distant.cpp'. A few thoughts: -...

It seems relatively complicated to implement fmod this way. Can you not use the same approach as in `array_router.h`?

(ping, is this still relevant?)

I think @superdump's request would be to have some auto-translation from standard STL constructs for dynamic arrays, which may be useful to have at some point. My suggestion would be...

Maybe it's just a documentation issue. In the upcoming Enoki, this would be written as ``` ek::unravel(ek::load(my_std_vector.data(), my_std_vector.size())); ```

They are reused if your computation results in the same assembly code. You can see this by increasing the debug level a bit and checking if there are "cache hit"...