mitsuba3 icon indicating copy to clipboard operation
mitsuba3 copied to clipboard

Implementation of OptiX Denoiser from OptiX 7.2 SDK. 2021 spring semester project

Open HVYVince opened this issue 4 years ago • 3 comments

Description

Integration of Optix Denoiser into Mitsuba2 and corresponding python bindings. Initial work, needs polishing

Checklist:

  • [ ] My code follows the style guidelines of this project
  • [x] My changes generate no new warnings
  • [x] My code also compiles for cuda_* and llvm_* variants. If you can't test this, please leave below
  • [x] I have commented my code
  • [x] I have made corresponding changes to the documentation
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] I cleaned the commit history and removed any "Merge" commits
  • [x] I give permission that the Mitsuba 2 project may redistribute my contributions under the terms of its license

HVYVince avatar Aug 18 '21 14:08 HVYVince

Hi Vincent,

thanks for the PR! As you already hint in the message, we won't merge it as-is, but this will be super-helpful in setting up the infrastructure for the OptiX denoiser.

Cheers, Wenzel

wjakob avatar Aug 23 '21 07:08 wjakob

Thanks for your work Vincent, this will be a great starting point for adding such a cool feature to the framework.

I would suggest we wait until the upcoming release to pick up this PR and continue working on this.

Speierers avatar Aug 27 '21 06:08 Speierers

No problem, thanks for your support through the semester and don't hesitate to ask if anything is unclear. Although I tend to think I'm the one it's the most unclear for 😅

HVYVince avatar Aug 27 '21 06:08 HVYVince