Matt Bishop

Results 67 comments of Matt Bishop

I'll work with a couple teams internally to resolve this. Seems simple enough at face value.

The public Bitwarden cloud shouldn't have any performance issues, but if one is using a local installation of course that's gonna be far less load and round-trip time for requests....

One issue: > Error: /home/runner/work/server/server/src/Identity/Startup.cs(181,21): error CS1061: 'HttpContext' does not contain a definition for 'SetIdentityServerOrigin' and no accessible extension method 'SetIdentityServerOrigin' accepting a first argument of type 'HttpContext' could be...

@justindbaur @rkac-bw this is ready for review again!

@justindbaur awesome tests! @rkac-bw can you give a final review stamp?

Closed in favor of #3832.

I am changing scope here, but a more fundamental question: are we getting benefit from what this is doing with queues? I thought it was added because it was available...

Closed in favor of #3832.

> I would prefer we stick with only checkmarx until all the teams are onboarded. > > Once that's done we can start evaluating code quality tools like sonar but...

Depends on https://github.com/bitwarden/server/pull/3751.