[deps] Vault: Update aspnet-health-checks monorepo (major)

[renovate[bot]]

This PR contains the following updates:

Package	Change	Age	Adoption	Passing	Confidence
AspNetCore.HealthChecks.AzureServiceBus	6.1.0 -> 8.0.0
AspNetCore.HealthChecks.AzureStorage	6.1.2 -> 7.0.0
AspNetCore.HealthChecks.Network	6.0.4 -> 8.0.0
AspNetCore.HealthChecks.Redis	6.0.4 -> 8.0.0
AspNetCore.HealthChecks.SendGrid	6.0.2 -> 8.0.0
AspNetCore.HealthChecks.SqlServer	6.0.2 -> 8.0.0
AspNetCore.HealthChecks.Uris	6.0.3 -> 8.0.0

---

Configuration

📅 Schedule: Branch creation - "every 2nd week starting on the 2 week of the year before 4am on Monday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

---

• [ ] If you want to rebase/retry this PR, check this box

---

This PR has been generated by Mend Renovate. View repository job log here.

[bitwarden-bot]

Checkmarx One – Scan Summary & Details – 8adc9b04-e253-4340-906b-88e47322be59

No New Or Fixed Issues Found

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 36.41%. Comparing base (0b56c0e) to head (5dc8df9).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #3294   +/-   ##
=======================================
  Coverage   36.40%   36.41%           
=======================================
  Files        1158     1158           
  Lines       56040    56012   -28     
  Branches     5384     5378    -6     
=======================================
- Hits        20400    20395    -5     
+ Misses      34693    34675   -18     
+ Partials      947      942    -5     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[shane-melton]

Holding off until https://github.com/bitwarden/server/pull/3461 is merged

[renovate[bot]]

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠ Warning: custom changes will be lost.

[shane-melton]

AspNetCore.HealthChecks.AzureStorage was split into separate packages for Queues, Blobs, and File Shares.

I added the relevant Queues health check package for .Net 8 and updated our usage accordingly. It now expects a QueueServiceClient to be registered in the service collection to be re-used or a factory must be provided. (more info on this change here)

I opted to register the QueueServiceClient singletons in the service collection to keep the underlying functionality the same as the original AspNetCore.HealthChecks.AzureStorage package that kept an internal long-lived cache of the QueueServiceClient. This avoids having QueueServiceClients recreated on every health check request and is the recommended practice.

I was also forced to add <PackageReference Include="Microsoft.Bcl.AsyncInterfaces" Version="8.0.0" /> as that seems to be dependency of the new <PackageReference Include="AspNetCore.HealthChecks.Azure.Storage.Queues" Version="8.0.0" /> that isn't being included properly. (There's a related issue open here)

[withinfocus]

I am changing scope here, but a more fundamental question: are we getting benefit from what this is doing with queues? I thought it was added because it was available but this is not in use by us today unless I am misunderstanding something. How about we remove everything but the Uris and SqlServer packages? That's what represents the core of our offering to me. This is surrounded by a check to exclude self-host and we don't use it in our Docker HEALTHCHECK so I would rather tone this all down now and then consider building it up later, once it's in use for our k8s-powered world. This is adding technical debt with the workaround. Swinging in the other direction I see at least half a dozen more dependencies we could add but don't think that's the right answer today.

[shane-melton]

I've removed the unused health check services and their dependencies (Azure Queue Storage, Azure Service Bus, Redis, and Send Grid) after confirming with CloudOps they're not in use.