server icon indicating copy to clipboard operation
server copied to clipboard

SAST with CodeQL

Open withinfocus opened this issue 1 year ago • 3 comments

Type of change

- [ ] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [X] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Adds CodeQL scanning.

Code changes

  • .github/workflows/scan.yml: New workflow dedicated for scanning.

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • If making database changes - make sure you also update Entity Framework queries and/or migrations
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

withinfocus avatar Feb 08 '24 21:02 withinfocus

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (3e73f1c) 39.32% compared to head (0244e3d) 39.32%. Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3773      +/-   ##
==========================================
- Coverage   39.32%   39.32%   -0.01%     
==========================================
  Files        1032     1032              
  Lines       51038    51056      +18     
  Branches     4579     4581       +2     
==========================================
+ Hits        20071    20076       +5     
- Misses      30025    30036      +11     
- Partials      942      944       +2     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 08 '24 21:02 codecov[bot]

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

Logo Checkmarx One – Scan Summary & Details52b450ab-3a68-4b4e-8a40-48ada4ee0147

No New Or Fixed Issues Found

bitwarden-bot avatar Feb 08 '24 23:02 bitwarden-bot

Closed in favor of #3832.

withinfocus avatar Feb 22 '24 18:02 withinfocus