Consolidated scanning

[withinfocus]

Type of change

- [ ] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [X] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Consolidates scanning for several tools into one unified workflow.

Code changes

• .github/workflows/scan.yml: New workflow.

Before you submit

• Please check for formatting errors (dotnet format --verify-no-changes) (required)
• If making database changes - make sure you also update Entity Framework queries and/or migrations
• Please add unit tests where it makes sense to do so (encouraged but not required)
• If this change requires a documentation update - notify the documentation team
• If this change has particular deployment requirements - notify the DevOps team

[github-advanced-security[bot]]

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (70fac80) 36.36% compared to head (95adf4b) 36.36%. Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #3832   +/-   ##
=======================================
  Coverage   36.36%   36.36%           
=======================================
  Files        1158     1158           
  Lines       55884    55885    +1     
  Branches     5376     5376           
=======================================
+ Hits        20324    20325    +1     
  Misses      34614    34614           
  Partials      946      946           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[bitwarden-bot]

Checkmarx One – Scan Summary & Details – aed11698-88b6-41ed-ae91-a7a8dd71f937

New Issues

Severity	Issue	Source File / Package	Checkmarx Insight
	Unpinned Actions Full Length Commit SHA	/build.yml: 473	Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
	Unpinned Actions Full Length Commit SHA	/build.yml: 207	Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
	Unpinned Actions Full Length Commit SHA	/build.yml: 581	Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
	Unpinned Actions Full Length Commit SHA	/build.yml: 506	Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...

Fixed Issues

Severity	Issue	Source File / Package
	Unpinned Actions Full Length Commit SHA	/build.yml: 566
	Unpinned Actions Full Length Commit SHA	/build.yml: 205
	Unpinned Actions Full Length Commit SHA	/build.yml: 491
	Unpinned Actions Full Length Commit SHA	/build.yml: 458

[sonarqubecloud[bot]]

Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

[sonarqubecloud[bot]]

Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

[withinfocus]

I would prefer we stick with only checkmarx until all the teams are onboarded.

Once that's done we can start evaluating code quality tools like sonar but we need to have the capacity to triage the existing backlog before those tools provide any value. Prior to that it's just noise and people start to quickly ignore them.

At the same time I want to build up real findings so we can adjust direction if needed. We've tested these tools in the past and reports are light, but I still want to see it really working. I do agree that we want to avoid noise, and given that we'll disable CodeScene (that is that to me) this could be a net win immediately.