Simon Wisselink

Results 211 comments of Simon Wisselink

@LaKanDoR this is a massive PR, adding a lot of (seemingly unnecessary) files. I'm a big fan of more unit tests, especially for scope matters, but I also notice that...

You can find the Smarty security policy here: https://github.com/smarty-php/smarty/blob/master/SECURITY.md But it would probably be good to add a page to the documentation as well, thank you for suggestion.

Hmm, I think you are trying to run Smarty v3 with PHP8. The problem is actually with 3.1.46 and before, not with 3.1.47 or 48: ``` $ composer require smarty/smarty:3.1.48...

This could be a problem. I opened #988 because I suspected that there might be a problem there. Will have to take a look at it.

@ParamjitKahai happy to help, if you can provide some details about the problem you are encountering.

I agree. You are saying it doesn't?

How does this relate to the compile_check setting?

> compile_check requires source template files to be present You are right. Even with $compile_check enabled, Smarty still checks if source files exist, although it won't compare the timestamps. I...

Could you try `composer require smarty/smarty:dev-smarty5` and let me know how that works for you? ```php