Simon Wisselink

Results 211 comments of Simon Wisselink

So we don't have 2 open issues for the same problem.

Re-opening this, since it seems #964 is fixed (for Smarty > v4), but we cannot port that fix to Smarty v5.

I'll have a look at it. But to be honest, right now I still doubt if we really need this.

> I was worried about that. That's why I asked before spending the time to update the tests. I really hope it makes it in. I know it's not a...

@ssigwart I'm considering adding `assignByRef` back, but still not entirely convinced. I understand that the removal of `assignByRef` may require changes to your application, but as the documentation for smarty...

@simplexx sorry to hear that. Could you share one or two examples of code where the variable is changed after it was assigned?

The var1, var2, var3 shorttag order got into the release candidates for smarty 5 by accident. They didn't exist in Smarty v4 either. We should be able to support this...

I can make this work, but only when using the 'global' scope: ```smarty {assign var="b" value="x" scope="global"} ``` ```php $smarty->getTemplateVars('b') // = 'x' ```

You are right. The change was documented in the changelog as "Template variable scope bubbling has been simplified and made more consistent. The global scope now equals the Smarty scope...

Please see https://smarty-php.github.io/smarty/stable/upgrading/#using-native-php-functions-or-userland-functions-in-your-templates