Simon Wisselink comments

Results 211 comments of


                                            Simon Wisselink

Smarty5: installation without composer

Don't forget src/functions.php!

Smarty v5 built-in json_encode modifier doesn't take Smarty $_CHARSET encoding into account, and can't be overridden using registerPlugin()

But if you consider this to be a bug in the default implementation, we should probably fix that instead?

Smarty v5 built-in json_encode modifier doesn't take Smarty $_CHARSET encoding into account, and can't be overridden using registerPlugin()

I'd be happy to have a look, but I need some more specifics. Can you share a reproduction scenario and your fixed version of the modifier?

Smarty v5 built-in json_encode modifier doesn't take Smarty $_CHARSET encoding into account, and can't be overridden using registerPlugin()

Uhm. What address is that? 🤔

Smarty v5 built-in json_encode modifier doesn't take Smarty $_CHARSET encoding into account, and can't be overridden using registerPlugin()

I got a hold of your email. It seems to me you are fixing something in your templates that ought to be fixed before the data is passed to Smarty...

Smarty v5 built-in json_encode modifier doesn't take Smarty $_CHARSET encoding into account, and can't be overridden using registerPlugin()

Ah I think I see what you mean now. So, basically what you are saying is that you are running Smarty in another charset and all input data is passed...

Smarty v5 built-in json_encode modifier doesn't take Smarty $_CHARSET encoding into account, and can't be overridden using registerPlugin()

Ah perfect. Would you like to create the PR?

Smarty v5 built-in json_encode modifier doesn't take Smarty $_CHARSET encoding into account, and can't be overridden using registerPlugin()

Mostly correct, but just add your modifier as a method to DefaultExtension. I try to avoid polluting the global namespace and have been reducing the amount of global functions. What...

Website www.smarty.net hacked?

I'm afraid I don't have any say about the website.

Error: Call to undefined method Smarty\Smarty::setErrorUnassigned()

Wow, after inspecting the code, I was going to say that `setErrorUnassigned` does not exist in Smarty 4 either. But even though it is not defined, calling `$this->smarty->setErrorUnassigned(true);` indeed actually...