William Cheng comments

Results 983 comments of


                                            William Cheng

[Java] Add support of 'x-obfuscated' property allowing for generated model classes an obfuscation of sensitive data (e.g. password) in toString() output (#2662)

> Build with samples profile (-Psamples) fails on server/java-msf4j, and this is not related to the fix. I've fixed that in the latest master.

[Java] Add support of 'x-obfuscated' property allowing for generated model classes an obfuscation of sensitive data (e.g. password) in toString() output (#2662)

@SergeyLyakhov can you merge the latest `origin/master` to see if the CI errors are fixed?

[Java] Add support of 'x-obfuscated' property allowing for generated model classes an obfuscation of sensitive data (e.g. password) in toString() output (#2662)

@SergeyLyakhov thanks. Let's see if all the tests pass.

[Java] Add support of 'x-obfuscated' property allowing for generated model classes an obfuscation of sensitive data (e.g. password) in toString() output (#2662)

@SergeyLyakhov I would appreciate if you can do (1) and (2) in a single PR based on the latest master. I'll do (3) and (4) later after merging the PR.

Feature/success code responses

@ignaciomolina let me review tomorrow. Sorry for the delay.

Feature/success code responses

@ignaciomolina the change breaks the Pistache generator: ``` [main] INFO io.swagger.parser.Swagger20Parser - reading from modules/swagger-codegen/src/test/resources/2_0/petstore.yaml [main] INFO io.swagger.codegen.AbstractGenerator - writing file /root/src/github.com/swagger-api/swagger-codegen/samples/server/petstore/pistache-server/model/ApiResponse.h [main] INFO io.swagger.codegen.AbstractGenerator - writing file /root/src/github.com/swagger-api/swagger-codegen/samples/server/petstore/pistache-server/model/ApiResponse.cpp [main]...