William Cheng

Results 983 comments of William Cheng

i think that's resolved in the latest master can you please merge the latest master into your branch?

please follow step 3 to update samples so that CI can verify the change

can you please review the CI failure when you've time?

do you need help updating the samples to fix https://github.com/OpenAPITools/openapi-generator/actions/runs/15577774453/job/44161740116?pr=21373 ?

cc @TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @topce (2018/10) @akehir (2019/07) @petejohansonxo (2019/11) @amakhrov (2020/02) @davidgamero (2022/03) @mkusaka (2022/04) @joscha (2024/10)

me neither - i got "page not found" anyway node 0 tests in circleci is not related to typescript: https://github.com/OpenAPITools/openapi-generator/blob/master/CI/circle_parallel.sh#L116 so it can be ignored for this change

there's a PR for it: https://github.com/OpenAPITools/openapi-generator/pull/17696

thanks for the PR. we definitely welcome enhancements. i wonder if you can add a test or 2 to cover this change as part of this PR.