William Cheng

Results 424 comments of William Cheng

circleci failure not related to this change.

The samples can show the exact change to the auto-generated code, which makes the review much easier. Without that, it's hard to visual the change.

I've just changed to the target branch to "master", which is the upcoming v6.1.0 release. Can you please resolve the merge conflicts when you've time?

can you please regenerate the samples?

No worry. I'll update the samples after the merge. Tested locally with updated samples and the result is good.

@chrisbartoloburlo thanks for the PR. cc @clasnake (2017/07), @jimschubert (2017/09) ❤️, @shijinkui (2018/01), @ramzimaalej (2018/03), @chameleon82 (2020/03), @Bouillie (2020/04)

@chrisbartoloburlo can you please resolve the merge conflicts when you've time? @bgong-mdsol does this PR look good to you?

Can you please share some spec that can help reproduce the issue mentioned in the PR description?

@bgong-mdsol thanks for reviewing this change. Is it correct to say that you've tested this PR locally and it works well with your spec? I'm also try to run some...

Tested locally and the result is good: ``` [INFO] Scanning for projects... [INFO] [INFO] ------------< org.openapitools:scalaz-sttp-petstore-client >------------ [INFO] Building scala-sttp-petstore-client 1.0-SNAPSHOT [INFO] --------------------------------[ pom ]--------------------------------- [INFO] [INFO] --- exec-maven-plugin:1.5.0:exec (sbt-test)...