William Cheng comments

Results 983 comments of


                                            William Cheng

Fix ObjectSerializer::isEmptyValue to not consider "0" as ""

thanks for the PR cc @jebentier (2017/07), @dkarlovi (2017/07), @mandrean (2017/08), @jfastnacht (2017/09), @ybelenko (2018/07), @renepardon (2018/12)

Fix ObjectSerializer::isEmptyValue to not consider "0" as ""

thanks for the PR, which has been merged. please give it a try with the latest snapshot version (should be published in an hour or so), which can be found...

[BUG][Java][Spring] Syntax error in generated API/Controller code when using example definition

@AdrianDiemerDev thanks for the additional info. Do you mind doing a `git bisect` to identify which commit reintroducing the issue when you've time?

(Java) Option to disable truncating prefixes for enums

@DwayneJengSage your request sounds reasonable to me. May I know if you've time to contribute the enhancement? If yes, I can show you some good starting points. @lbilger which version...

(Java) Option to disable truncating prefixes for enums

@DwayneJengSage Thanks for offering help. I may be able to work on this feature over the weekend. If not, I'll send you more details. Stay tuned.

[Java] [Spring] Use deduction configOptions for oneOfInterfaces

@jpfinne sorry for late review as there are too many PRs can you resolve the merge conflicts when you've time? I'll try to get it merged and included in the...

[Java] [Spring] Use deduction configOptions for oneOfInterfaces

Just merged. Sorry for the delay Thanks for the PR as always

[typescript-angular] fix: when model property name is sanitized, use instead original property name within quotes in mustache template

can we add a test model with the property name in question to the test spec used by the typescript-angular petstore (fake) sample so that we know what the output...

[typescript-angular] fix: when model property name is sanitized, use instead original property name within quotes in mustache template

when you've time, can you also please PM me via Slack? https://join.slack.com/t/openapi-generator/shared_invite/zt-12jxxd7p2-XUeQM~4pzsU9x~eGLQqX2g

[typescript-angular] fix: when model property name is sanitized, use instead original property name within quotes in mustache template

as discussed, I think this enhancement should only be applied to "original" modelPropertyNaming (when such option is enabled) you tried the "original" modelPropertyNaming option before but it didn't work for...