William Cheng

Results 983 comments of William Cheng

@iamkarlson thanks for the PR. I'll review later this week.

@iamkarlson Please run `.\bin\windows\csharp-petstore-all.bat` to update the C# Petstore samples. I got compilation errors after updating the samples: ``` Using shared compilation with compiler from directory: C:\Program Files (x86)\MSBuild\14.0\Bin Client\ApiClient.cs(203,58):...

@iamkarlson thanks for fix. Most issues are gone except the following: I'm using Xamarin 6.2 on MacOS with Mono 4.8.1 Did you get similar error locally? CI (AppVeyor) also reports...

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in...

Can you please also elaborate on what this PR does? Is there an issue/ticket opened for this?

> Codegen doesn't generate class when an object defined with an empty properties list Can you share more about the use case with an empty properties list?

@korkut89 sorry I mean why an object is defined without properties? I think only a handful of programming languages support empty object (an object without property) What does the corresponding...

@korkut89 thanks for sharing more. Given that the JSON payload is well-defined, why define it as an empty object?

@korkut89 I think the spec owner will need to update the spec to have a proper definition of the model with valid properties instead.

I agreed with you guys the spec is valid according to the specification. My point is without knowing how the object (JSON, XML) is defined, how can any developers figure...