openapi-generator icon indicating copy to clipboard operation
openapi-generator copied to clipboard

[typescript-angular] fix: when model property name is sanitized, use instead original property name within quotes in mustache template

Open davidediak opened this issue 1 year ago • 2 comments

Fixes #19352

Technical committee

@TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @topce (2018/10) @akehir (2019/07) @petejohansonxo (2019/11) @amakhrov (2020/02) @davidgamero (2022/03) @mkusaka (2022/04)

PR checklist

  • [X] Read the contribution guidelines.
  • [X] Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • [x] Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH) Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • [X] File the PR against the correct branch: master (upcoming 7.6.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • [X] If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

davidediak avatar Aug 14 '24 08:08 davidediak

@wing328 do you plan on merging this soon or there are any issues?

davidediak avatar Aug 27 '24 09:08 davidediak

  • 1 on this feature please. in our case some props have - in them for some reason.

LPCmedia avatar Aug 27 '24 15:08 LPCmedia

can we add a test model with the property name in question to the test spec used by the typescript-angular petstore (fake) sample so that we know what the output looks like and the result works without issue?

wing328 avatar Aug 29 '24 05:08 wing328

when you've time, can you also please PM me via Slack?

https://join.slack.com/t/openapi-generator/shared_invite/zt-12jxxd7p2-XUeQM~4pzsU9x~eGLQqX2g

wing328 avatar Aug 29 '24 05:08 wing328

as discussed, I think this enhancement should only be applied to "original" modelPropertyNaming (when such option is enabled)

you tried the "original" modelPropertyNaming option before but it didn't work for you.

i'll investigate further over the weekend.

wing328 avatar Aug 30 '24 09:08 wing328

closed via https://github.com/OpenAPITools/openapi-generator/pull/19508

thanks for the PR

please pull the latest master to give it a try when you've time

wing328 avatar Sep 02 '24 09:09 wing328