Sebastian Wilzbach

Results 359 comments of Sebastian Wilzbach

Not sure about this. There's now an awful lot of space. Before: ![image](https://user-images.githubusercontent.com/4370550/33918499-fbe0ae0c-dfb3-11e7-89fd-648d8d75ec63.png) After: ![image](https://user-images.githubusercontent.com/4370550/33918496-f6c8c26a-dfb3-11e7-9d37-8d8486dc8287.png)

> Just a short excerpt from the VERY LARGE log file: Ouch 143M log file?? Fixed & this is passing now, but it seems that the assert->rewrite pipeline isn't working...

> but it seems that the assert->rewrite pipeline isn't working correctly anymore :/ Luckily I have been working on a separate PR that simplifies this pipeline: https://github.com/dlang/dlang.org/pull/2069 - this should...

Argh. I realized a big problem with this. We can't do this within the two weeks before release where `master` got merged into stable, but didn't get fully released yet....

before: ![image](https://user-images.githubusercontent.com/4370550/33923850-ad0bf262-dfd3-11e7-8620-aa112f142d84.png) after: ![image](https://user-images.githubusercontent.com/4370550/33923841-a0b2ffc4-dfd3-11e7-9eff-19c2d286a0a6.png) ---------------- before: ![image](https://user-images.githubusercontent.com/4370550/33923863-c0900472-dfd3-11e7-9e33-e15a564441af.png) after: ![image](https://user-images.githubusercontent.com/4370550/33923868-c6c7c1c2-dfd3-11e7-9320-56b5c755d7fa.png) --- before: ![image](https://user-images.githubusercontent.com/4370550/33923946-159be4d6-dfd4-11e7-91ec-c677af79957b.png) after: ![image](https://user-images.githubusercontent.com/4370550/33923902-eaf271e6-dfd3-11e7-90fc-6758083e18f7.png)

So yeah the first listing looks a bit worse afterwards. before: ![image](https://user-images.githubusercontent.com/4370550/33924025-6c585b9c-dfd4-11e7-8011-660947249c15.png) after: ![image](https://user-images.githubusercontent.com/4370550/33923996-51a1883c-dfd4-11e7-8055-e1e3c963a6c3.png)

A start -> https://github.com/dlang-community/D-Scanner/pull/585

> This probably needs Andrei's sign-off, and he has historically been against moving things around under the hood... Okay. I will refrain from fixing the CIs until then (shouldn't be...

You might want to have a look at a very similar attempt: `reserve` -> https://github.com/dlang/druntime/pull/1929

(This is just something we agreed on for Phobos (https://dlang.org/dstyle.html#phobos_declarations) to have more consistent styling.)