dfmt icon indicating copy to clipboard operation
dfmt copied to clipboard

indentation of constraints are not on the same level, violating Dstyle

Open timotheecour opened this issue 6 years ago • 5 comments

see https://github.com/dlang/tools/pull/310#discussion_r166816020 for context image

timotheecour avatar Feb 08 '18 19:02 timotheecour

embedded the dropbox image for you so people don't need to go to an external website

WebFreak001 avatar Feb 08 '18 20:02 WebFreak001

(This is just something we agreed on for Phobos (https://dlang.org/dstyle.html#phobos_declarations) to have more consistent styling.)

wilzbach avatar Feb 08 '18 20:02 wilzbach

@WebFreak001 silly question, what did you use to generate https://user-images.githubusercontent.com/2035977/35995443-a4ea249c-0d13-11e8-8716-b0ab82c6cef5.png from the dropbox link i had? the answers in https://stackoverflow.com/questions/14494747/add-images-to-readme-md-on-github seem to suggest hosting on one's own repo, unlike yours

timotheecour avatar Feb 09 '18 09:02 timotheecour

I copied the image and did ctrl-v in the github comment editor, it uploads it. It's the same like drag and dropping the image in here

WebFreak001 avatar Feb 09 '18 09:02 WebFreak001

And some constraints are moved to the previous line:

-auto ddemangle(T)(T line)
-    if (is(T : const(char)[]));
+auto ddemangle(T)(T line) if (is(T : const(char)[]));
 
 const(char)[] demangleMatchUnderscoreMissing(T)(Captures!(T) m)
-    if (is(T : const(char)[]));
+            if (is(T : const(char)[]));

belka-ew avatar Apr 14 '20 05:04 belka-ew