Sebastian Wilzbach

Results 359 comments of Sebastian Wilzbach

BTW at the end we need to squash all commits into one, so I recommend to use rebases instead of merge commits as then the final squashing is easier (though...

Great the GC is segfaulting here: ``` Program received signal SIGSEGV, Segmentation fault. 0x0000000000b17fec in gc.impl.conservative() (this=..., ptop=0x608f670, pbot=0x608f630) at src/gc/impl/conservative/gc.d:1990 1990 auto p = *p1; #0 0x0000000000b17fec in gc.impl.conservative()...

> The style checker fails to consider default arguments in ddoc parameter counting. I rechecked by hand and all passable parameters have ddoc comments. It's not even the style checker...

We can make breaking changes with experimental packages as long as the project tester passes. In this case it's libasync which depends on std.experimental.logger. Anyhow as you also have other...

@edi33416 I recommend splitting this PR up into smaller chunks, s.t. it can be reviewed and merged more quickly. As an additional benefit your chances of running into merge conflicts...

Ping @edi33416

I like the idea (and I'm generally in favor of using more `Nullable` / `Optional` in Phobos). However a few concerns for now: - should we really promote a different...

> Is Nullable.apply nothrow? > Can we feed Nullable.apply a lambda and still be nothrow? Yes and even `@nogc` e.g. https://github.com/dlang/phobos/blob/bb769cfaf51f32a9f20567f885361fe828e9f8a3/std/typecons.d#L3807-L3823 See also: https://dlang.org/changelog/2.080.0.html#std-typecons-nullable-apply That's because `Nullable.get` doesn't use exceptions,...

> Nothing outside std.experimental is allowed to use std.experimental. Nope, that's not true. You can't return experimental types, but Phobos __is allowed__ to use things from experimental internally. We do...