William Ha

Results 39 comments of William Ha

Maybe while you're at it, throw in #2592

Alternate implementation: No need for an additional systemd service. Instead, have the "Restart Thunderloop" button call `ansible_runner` from `run_ansible.py` to ssh into the robot and run an ansible script that...

> Did the software tests fail because of the erroneous removal of the `requirements_lock.txt` by the auto fix? I'm not familiar with how the CI works yet Looks like it,...

I see your point now about why we might not want to automatically run the formatting script, and instead just give a warning to the user. Actually, it reminds me...

Alanna says mech is working on some sort of dribbler dampening project, so if we move backwards slightly while receiving, that might cause problems. We'll temporarily hold off on this...

> Looks right to me, except I think Andrew wanted .hasValue(), not just best_pass_so_far. Unless it's implied in the if statement, but it looks a bit weird without the .hasValue()...

> > looks good, left something minor comments! have you field tested this version yet? > > Not yet!! I believe last time we tried to field test it there...

Thanks @itsarune for the detailed toolchain docs -- very helpful documentation to have!

Spoke with Grayson and we're going to close this PR for now in favour of #3458 which will have similar functionality (enabling/disabling individual motors). We can port over the remaining...