Software icon indicating copy to clipboard operation
Software copied to clipboard

Added ability to control pulse width for kick and chip commands in RobotDiagnostics

Open wmostrenko opened this issue 10 months ago • 4 comments

Please fill out the following before requesting review on this PR

Description

Added the ability to toggle between "m/s or m" power mode or "pulse width" power mode when kicking/chipping in robot diagnostics. Also added a slider to manually control the pulse width for the kicker and chipper. Also works for autokick/autochip.

Testing Done

Testing will need to be done with robots as when we tried previously there we too many technical difficulties connecting my computer to the robots.

Resolved Issues

resolves #3329

Length Justification and Key Files to Review

Review Checklist

It is the reviewers responsibility to also make sure every item here has been covered

  • [X ] Function & Class comments: All function definitions (usually in the .h file) should have a javadoc style comment at the start of them. For examples, see the functions defined in thunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.
  • [ X] Remove all commented out code
  • [X ] Remove extra print statements: for example, those just used for testing
  • [X ] Resolve all TODO's: All TODO (or similar) statements should either be completed or associated with a github issue

wmostrenko avatar Feb 27 '25 05:02 wmostrenko

This PR is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] avatar Apr 27 '25 03:04 github-actions[bot]

looks good, left something minor comments! have you field tested this version yet?

Not yet!! I believe last time we tried to field test it there was some sort of issue connecting to the robots so perhaps we could try again if you're available sometime soon to show me how as I completely forgot? Thanks!

wmostrenko avatar Jun 29 '25 00:06 wmostrenko

looks good, left something minor comments! have you field tested this version yet?

Not yet!! I believe last time we tried to field test it there was some sort of issue connecting to the robots so perhaps we could try again if you're available sometime soon to show me how as I completely forgot? Thanks!

We're in the mezz every saturday, so feel free to swing by and I can help! (or lmk if you want me to just field test for you)

williamckha avatar Jun 29 '25 03:06 williamckha

looks good, left something minor comments! have you field tested this version yet?

Not yet!! I believe last time we tried to field test it there was some sort of issue connecting to the robots so perhaps we could try again if you're available sometime soon to show me how as I completely forgot? Thanks!

We're in the mezz every saturday, so feel free to swing by and I can help! (or lmk if you want me to just field test for you)

Great sounds good!! I'll drop by soon when find some time! Thanks!

wmostrenko avatar Jul 02 '25 06:07 wmostrenko