Wiktor Kwapisiewicz

Results 186 comments of Wiktor Kwapisiewicz

This took a liiiitle bit longer than I expected but I've submitted a patch to Sequoia to include OpenSSL backend: https://gitlab.com/sequoia-pgp/sequoia/-/merge_requests/1361 It passes all tests (and adds some more) and...

For people that track the subject the OpenSSL backend has been merged and released in sequoia-openpgp crate 1.13.0: https://gitlab.com/sequoia-pgp/sequoia/-/blob/main/openpgp/NEWS#L6 Have a nice day! 👋

I'm actually happy with the rest of the tags that the extension inserts (the rest of the OpenGraph tags). But as you mention it's possible to do the same via...

Couldn't serialization just work on Envelope objects (or Envelope-like objects, that is JSON + buffers)? So that this would be an identify function: `X => serialize(new Envelope(X))` (approximately). The consumer...

Oh, I see my idea already has an issue: https://github.com/jhermsmeier/node-envelope/issues/10. Sorry for duplication :)

:thinking: it looks like it fails due to bad formatting. If you could try something like this locally: ``` cargo fmt git commit -a --amend --no-edit --signoff git push --force...

> stupid mistake... doing too many things at once. Haha, no worries, I can totally relate! As for the `let` error that happened in last build maybe you can try...

If you don't mind I'll rebase your PR, fix the remaining issues and merge (preserving the authorship - of course). :wave:

I can reproduce this problem. Adding `generate-bindings` feature does not help. I did succeed when I used crate directly via git: `cryptoki = { version = "0.4.1", git = "https://github.com/parallaxsecond/rust-cryptoki"...

The use-case is good and I like your ideas. :+1: While looking at your proposed API it makes a striking resemblance to the [Iterator API](https://doc.rust-lang.org/std/iter/trait.Iterator.html). Just wondering, have you considered...