Wiktor Kwapisiewicz

Closing this since https://github.com/parallaxsecond/rust-cryptoki/pull/228 got merged.

I guess deprecating it in one version and then only removing it in a major version bump would be a conservative choice.

@FiloSottile I've rebased on top of `main` and fixed conflicts.

> I think we should just expose the id and key like what Github did. i.e. https://api.github.com/users/lunny/keys There's a slight problem that the time cannot be `nil`'d. Although I [found...

> If you don't mind, I can send some commits to your PR. I would be very glad if you could help :pray: thank you in advance! :bow:

> Ideally you would fetch those in a client that does not require CORS, e.g. in the backend. Yes, that's a workaround I could use but the point of my...

> I hope the public does not mean unauthenticated for private instances? 🤔 It's the same kind of access that is available through the `.keys` endpoint (but with JSON+CORS): ```...

> I mean it should be still inaccessible if gitea instance is set to always require authentication (`REQUIRE_SIGNIN_VIEW=true`) Yeah, just to be crystal clear: I *don't* want to relax *that*....

> PR title should be fixed that as it is quite misleading "unauthenticated access" Okay, what do you suggest? `.keys` is available to users who are not logged in ([example...

Btw, while my local tests of tpm-box went just fine running `TEST_TCTI=libtpms cargo test --no-default-features --features generate-bindings` generates quite a lot of failures: ``` ... test structures_tests::pcr_tests::pcr_select_size_tests::test_invalid_conversions ... [2024-09-12T10:04:22Z ERROR...