Wiesław Šoltés

Results 243 comments of Wiesław Šoltés

If it was for me to decide I would make or default values null. To solve null issues I would add nullable reference annotations, that way end user can see...

> Marking it as nullable would technically be a correct option, but it would really hurt usability. The user would have to inject the very same code you're avoiding everywhere...

Something to keep in mind. The empty SvgElement is 712 bytes ``` | Method | Mean | Error | StdDev | Op/s | Ratio | RatioSD | Rank | Gen...

Seems like Fizzler supports `.NETStandard 1.0` and `.NETStandard 2.0`: https://www.nuget.org/packages/Fizzler https://github.com/atifaziz/Fizzler#fizzler-net-css-selector-engine

**__issue-789-03.svg** ```svg ``` **__issue-789-0_.NETCoreApp,Version=v2.1.svg** ```svg ``` **__issue-789-0_.NETCoreApp,Version=v3.1.svg** ```svg ``` **__issue-789-0_.NETCoreApp,Version=v5.0.svg** ```svg ``` **__issue-789-0_.NETFramework,Version=v4.5.2.svg** ```svg ``` **__issue-789-0_.NETFramework,Version=v4.6.1.svg** ```svg ``` **Test** ```C# [Test] public void Test_Issue_789() { var svgPath = Path.Combine(AssemblyDirectory, "..",...

Tested color string and they all work: ```C# [TestCase("#f0f0f0")] [TestCase("#000000")] public void Test_Issue_789_SvgColourConverter_ConvertFrom(string hex) { var converter = new SvgColourConverter(); var color = converter.ConvertFrom(null, CultureInfo.InvariantCulture, hex); Assert.NotNull(color); Assert.AreEqual(typeof(Color), color.GetType()); }...

Simpler repro: ```svg ``` the issue is when document is saved and loaded again the style is not preserved