Gang Wu comments

Results 304 comments of


                                            Gang Wu

[PARQUET-2448] fix model conversions for avro <= 1.8 generated classes

I need to spend some time to get familiar with the code path. cc avro experts @gszadovszky @Fokko .

PARQUET-2446: ProtoParquetWriter support dynamic message

Thanks for the fix! Could you add a test case please?

[WIP][Proposal] PARQUET-2430: Add parquet joiner

cc @gszadovszky @ggershinsky @ConeyLiu in case you've missed the ML discussion: https://lists.apache.org/thread/5q7qhkl07of4ypc4t5zx3hyjgv12c7q2

[WIP][Proposal] PARQUET-2430: Add parquet joiner

@MaxNevermind Sure, I will take a look this week.

[WIP][Proposal] PARQUET-2430: Add parquet joiner

Thanks for the update! I will take a look later this week. > Let me if you want me to implement your VerticalInputFile / HorizontalInputFile idea and what to do...

[WIP][Proposal] PARQUET-2430: Add parquet joiner

@ConeyLiu Would you mind taking a look as well?

PARQUET-2429: Reduce direct input buffer churn

> When decompressing a 64MB block using a 4KB chunk size, this leads to thousands of allocations and deallocations totaling GBs of memory. Is that a real use case? Usually...

PARQUET-2429: Reduce direct input buffer churn

Could you please make the CI happy? cc @gszadovszky @shangxinli

PARQUET-2429: Reduce direct input buffer churn

Sorry for the delay. I just merged this. Thanks!

PARQUET-2445: Fix log exception when FieldsMarker.visitedIndexes is empty

Thanks for the fix! @panbingkun