Gang Wu

Results 304 comments of Gang Wu

@zxf216 This error happens when reading dictionary-encoded string values. Please check following: - Check whether the dictionary data is correct. Especially pay attention to the number of entries in the...

> Thanks for the review @wgtmac! I've addressed some of it and will continue tomorrow. > > I'm still hitting an issue where `bit_writer_.PutZigZagVlqInt` (or other `bit_writer_.PutAligned`) work as expected...

> @wgtmac Thanks for the review. I addressed your comments. Outstanding items: FastDifferentialCoding & testing Put where `values.null_count() > 0`. Thanks for addressing the comments! The overall change looks good...

> @pitrou Hi, I tried to add some unittest and pass the tests. > > Now I generate some files from https://github.com/apache/parquet-mr/blob/master/parquet-hadoop/src/test/java/org/apache/parquet/hadoop/TestDataPageV1Checksums.java , should I first commit them to `parquet-test`...

Please do not forget to update `parquet.rst` for the new encoder implementation.

The ASAN UBSAN check is failed: https://github.com/apache/arrow/actions/runs/4616021690/jobs/8160523964?pr=14341 ``` [----------] 3 tests from DeltaByteArrayEncodingAdHoc [ RUN ] DeltaByteArrayEncodingAdHoc.ArrowBinaryDirectPut /arrow/cpp/src/arrow/buffer_builder.h:138:27: runtime error: null pointer passed as argument 2, which is declared to...

I will take a look in depth over the weekend. Hope it can be included in the 13.0.0 release as we have been wishing it for a long time.

> cc @ggershinsky @wgtmac let me know if you have concern to merge. Thanks for pinging me! I don't have any concern for now.

It looks good to me but I don't have the privilege to merge. May I request your help? @ggershinsky @shangxinli @gszadovszky

> Hello, it seems there were commits referencing this issue. Is this issue now fixed ? @LouisClt Thanks for your follow-up. We have implemented a block-based buffer called `BlockBuffer` (by...