parquet-java icon indicating copy to clipboard operation
parquet-java copied to clipboard

PARQUET-2446: ProtoParquetWriter support dynamic message

Open KingNF opened this issue 11 months ago • 3 comments

Make sure you have checked all steps below.

Jira

  • [x] My PR addresses the following Parquet Jira issues and references them in the PR title. For example, "ProtoParquetWriter doesn't Support DynamicMessage"

Tests

  • [x] My PR adds the following unit tests OR does not need testing for this extremely good reason:this change is simple and only affects the ProtoParquetWriter Builder function

Commits

  • [x] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Style

  • [x] My contribution adheres to the code style guidelines and Spotless passes.
    • To apply the necessary changes, run mvn spotless:apply -Pvector-plugins

Documentation

  • [x] In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain Javadoc that explain what it does

KingNF avatar Mar 08 '24 03:03 KingNF

Hello everyone, Can someone please check this PR when you are free? Many thanks!

KingNF avatar Mar 11 '24 06:03 KingNF

Thanks for the fix! Could you add a test case please?

wgtmac avatar Mar 11 '24 07:03 wgtmac

Thanks for your time, @wgtmac. have added a test case.

KingNF avatar Mar 12 '24 05:03 KingNF