parquet-java
parquet-java copied to clipboard
PARQUET-2446: ProtoParquetWriter support dynamic message
Make sure you have checked all steps below.
Jira
- [x] My PR addresses the following Parquet Jira issues and references them in the PR title. For example, "ProtoParquetWriter doesn't Support DynamicMessage"
Tests
- [x] My PR adds the following unit tests OR does not need testing for this extremely good reason:this change is simple and only affects the ProtoParquetWriter Builder function
Commits
- [x] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines
from "How to write a good git commit message":
- Subject is separated from body by a blank line
- Subject is limited to 50 characters (not including Jira issue reference)
- Subject does not end with a period
- Subject uses the imperative mood ("add", not "adding")
- Body wraps at 72 characters
- Body explains "what" and "why", not "how"
Style
- [x] My contribution adheres to the code style guidelines and Spotless passes.
- To apply the necessary changes, run
mvn spotless:apply -Pvector-plugins
- To apply the necessary changes, run
Documentation
- [x] In case of new functionality, my PR adds documentation that describes how to use it.
- All the public functions and the classes in the PR contain Javadoc that explain what it does
Hello everyone, Can someone please check this PR when you are free? Many thanks!
Thanks for the fix! Could you add a test case please?
Thanks for your time, @wgtmac. have added a test case.