Gang Wu

Results 304 comments of Gang Wu

> Hi @wgtmac - thanks for contributing to Spatial Framework for Hadoop. However - > > > The convex hull of a single geometry should be itself. > > No,...

+1 @guiyanakuang @dongjoon-hyun. This is a large feature. We can follow the java implementation and break it down into smaller work items first.

> Hi @dongjoon-hyun Do we have jira to track the work? @deshanxiao Not yet. @coderex2522 is working on it already. Will create JIRAs later.

@shangxinli Please take a look when you have time. Thanks!

@pitrou @shangxinli Can you please take a look? Thanks in advance!

> @wgtmac Did you try to read an actual file produced by Parquet C++? > > Note you can find such files in https://github.com/apache/parquet-testing/ Yes, I have tried that. I...

@shangxinli Thanks for the review. I haven't be able to run the benchmark since the Hadoop Lz4Codec is implemented via JNI and I cannot simply run it on my Mac...

The interop test has been added. Please take a look again. Thanks! @shangxinli @pitrou

> Looks good. The only thing is we checked in binary files directly. It would be hard to maintain in the future. Can you generate the parquet file using the...

> Yep, we test encryption interop using binary files in the parquet-testing repo. @wgtmac Please have a look at this code: https://github.com/apache/parquet-mr/blob/master/parquet-hadoop/src/test/java/org/apache/parquet/hadoop/TestEncryptionOptions.java#L130 @ggershinsky @emkornfield Yes I did that in the...