Gang Wu comments

Results 304 comments of


                                            Gang Wu

GH-2939: Update PULL_REQUEST_TEMPLATE

@rok @gszadovszky @Fokko @julienledem Would you mind taking a look?

GH-2939: Update PULL_REQUEST_TEMPLATE

Thanks for the suggestion! I've simplified the wording and removed unimportant comments. PTAL. @Fokko @gszadovszky

GH-2939: Update PULL_REQUEST_TEMPLATE

@Fokko Gentle ping :)

GH-2939: Update PULL_REQUEST_TEMPLATE

Thanks @Fokko for merging!

PARQUET-2471: Add support for geometry logical type

Thanks @paleolimbot for the quick review! I've addressed your feedback and also added page index support for geometry stats. BTW, it is a convention that we need PoC on another...

PARQUET-2471: Add support for geometry logical type

Thanks @jiayuasu for your valuable feedback! Yes, it would be great if we can get direct help from geospatial experts!

PARQUET-2471: Add support for geometry logical type

Close this in favor of https://github.com/apache/parquet-java/pull/2971

PARQUET-2464: Fix dictionaryPageOffset flag setting in toParquetMetadata method

``` Error: Failed to execute goal com.diffplug.spotless:spotless-maven-plugin:2.30.0:check (default) on project parquet-hadoop: The following files had format violations: Error: src/test/java/org/apache/parquet/format/converter/TestParquetMetadataConverter.java Error: @@ -1277,9 +1277,8 @@ Error: ····return·createParquetMetaData(dicEncoding,·dataEncoding,·true); Error: ··} Error: Error:...

Could we provide a potentially larger InternalParquetRecordWriter.getDataSize

Do you have any concrete suggestion on what value to provide? My concern is that changing the behavior may affect a lot of downstream applications in the wild without notice.

Document the behavior of Nested ColumnChunk statistics

ColumnChunk statistics is always for the leaf columns. I'm not familiar with DataFrame. The data in your example contains two lists: `[1, 2, 3]` and `null`. `null_count` includes null values...