Gang Wu comments

Results 304 comments of


                                            Gang Wu

Add test file with sorting columns

I think it is fine to use the same properties across all row groups.

Proof-of-concept Parquet GEOMETRY logical type implementation

Please ping me when ready for review again. Thanks!

[C++][Parquet] Expand ParquetVersion enum values

@diego-ciciani01 Feel free to create a PR :)

Adding testing page for Dictionary page after non-dict data page in same column-chunk

I think this is allowed from the spec: `A column chunk might be partly or completely dictionary encoded`. I'm not sure if any open source Parquet writer is able to...

Add more constructors to ParquetFileReader

I think it makes sense to add this. Please feel free to create a PR.

Add more constructors to ParquetFileReader

@steveloughran I have the same feeling. For the reader we already have `ParquetReadOptions`. The writer does not even have this parity.

GH-3141: Add constructor to ParquetFileReader to allow passing in parquet footer

BTW, could you also add a test case for it?

GH-3141: Add constructor to ParquetFileReader to allow passing in parquet footer

``` Error: Failed to execute goal com.diffplug.spotless:spotless-maven-plugin:2.30.0:check (default) on project parquet-hadoop: The following files had format violations: Error: src/main/java/org/apache/parquet/hadoop/ParquetFileReader.java Error: @@ -739,7 +739,8 @@ Error: ···*·@return·an·open·ParquetFileReader Error: ···*·@throws·IOException·if·there·is·an·error·while·opening·the·file Error: ···*/...

ExampleParquetWriter may write illegal values for uint_8 and uint_16

> Implementations must not write values that are larger than the annotation allows I agree that this should be fixed: https://github.com/apache/parquet-format/blob/master/LogicalTypes.md#unsigned-integers

GH-3074: read footer using 1 call readFully(byte[8]) instead of 5 calls

Could you try to rebase it? I think the CI failure is due to based on a problematic commit.